update to perlmutter tutorial page #1357
Conversation
docs/buildtest_perlmutter.rst
Outdated
|
|
||
| buildtest cdash upload $USER-buildtest-tutorial | ||
|
|
||
| Take some time to analyze the output in CDASH by opening the link including PASS/FAIL test. | ||
| Take some time to analyze the output in CDASH by opening the link. |
There was a problem hiding this comment.
What link? Is it provided by buildtest? If so, say that here.
There was a problem hiding this comment.
yeah the link is provided in output of buildtest cdash upload. They can also do buildtest cdash upload -o which will automatically open the link but on Perlmutter most likely they need to run this from X11 forwarding. The output shows link.
A typical example would look something like this
(buildtest) ~/Documents/github/buildtest/ [fix_perlmutter_tutorial_feedbacks_justin] buildtest cdash upload demo
Reading report file: /Users/siddiq90/Documents/github/buildtest/var/report.json
Uploading 110 tests
Build Name: demo
site: generic
MD5SUM: 66aab132ac8c51e283d37bf5b247739b
You can view the results at: https://my.cdash.org//viewTest.php?buildid=2278324
There was a problem hiding this comment.
That's fine. Just say something like 'the link to cdash provided by buildtest build' or whatever is generating it. That way they have some context
There was a problem hiding this comment.
ok i did clarify this with hyperlink to buildtest cdash section. This is good point you bring up since buildtest cdash was not covered in this page so this would be new for users.
|
@jscook2345 i tried to address all of your concerns, please take a look. You can see the rendered docs once CI check is complete. |
|
I added one more comment. Everything looks good so after you address that feel free to merge. |
@jscook2345 okay so i made some changes based on your feedback in #1338.