support for logical AND in status check via 'mode' #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o specify status check to be done as a 'or' 'and' which will be a logical OR/AND. add an example buildspec to demonstrate the example
…ks. We assign all status check into a dictionary as a lookup table. Refactored the codebase for status check logic and added support for logical AND when using 'mode: and'
shahzebsiddiqui
commented
Mar 22, 2023
update this change in buildspec examples, documentation, implementation
buildtest/builders/base.py
Outdated
| # check regex against output or error stream based on regular expression | ||
| # defined in status property. Return value is a boolean | ||
| regex_match = regex_check(self) | ||
| # returncode_match is boolean to check if reference returncode matches return code from test |
There was a problem hiding this comment.
@shahzebsiddiqui You can remove this comment since we are not using the variable "returncode_match".
prathmesh4321
requested changes
Mar 23, 2023
There was a problem hiding this comment.
@shahzebsiddiqui Please take a look at the above comment. Other than this the PR looks good to me !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.