Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs on assert less than #1439

Merged
merged 2 commits into from
Apr 17, 2023
Merged

docs on assert less than #1439

merged 2 commits into from
Apr 17, 2023

Conversation

Xiangs18
Copy link
Collaborator

@Xiangs18 Xiangs18 commented Apr 17, 2023 •
edited
Loading

Hi @shahzebsiddiqui, < docs is added.

@Xiangs18 Xiangs18 linked an issue Apr 17, 2023 that may be closed by this pull request
[DOCS]: missing docs on assert less than #1421
Closed
2 tasks
@shahzebsiddiqui
Copy link
Member

@prathmesh4321 can you please review this PR. Thanks @Xiangs18

prathmesh4321
prathmesh4321 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@prathmesh4321 prathmesh4321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahzebsiddiqui @Xiangs18 This looks good to me !

@shahzebsiddiqui shahzebsiddiqui merged commit e22c689 into devel Apr 17, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the add_docs branch April 17, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathmesh4321 prathmesh4321 prathmesh4321 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
No open projects
buildtest 1.4 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS]: missing docs on assert less than
3 participants
@Xiangs18 @shahzebsiddiqui @prathmesh4321