Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global option for --row-count #1463

Merged
merged 26 commits into from
May 5, 2023
Merged

global option for --row-count #1463

merged 26 commits into from
May 5, 2023

Conversation

Xiangs18
Copy link
Collaborator

@Xiangs18 Xiangs18 commented May 4, 2023

Screen Shot 2023-05-04 at 12 59 58 AM

shahzebsiddiqui
shahzebsiddiqui requested changes May 4, 2023
View reviewed changes
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay this looks pretty good. I just have one suggestion for changing the try/except with the with.

@shahzebsiddiqui shahzebsiddiqui merged commit 9e8b651 into devel May 5, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the row_count branch May 5, 2023 02:07
@shahzebsiddiqui
Copy link
Member

thanks @Xiangs18 this looks good. Great job!

@Xiangs18 Xiangs18 linked an issue May 5, 2023 that may be closed by this pull request
global option for --row-count #1387
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui requested changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global option for --row-count
2 participants
@Xiangs18 @shahzebsiddiqui