-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage for multiple compilers with script schema #1515
Conversation
Mariamajib
commented
Jul 5, 2023
•
edited
Loading
edited
- Created a symlink "stream_example.yml" to test the method process_compiler_config https://buildtest.readthedocs.io/en/devel/buildspecs/compiler.html#running-stream-benchmark-with-multiple-compilers
- Added method_process_compiler_config https://github.com/buildtesters/buildtest/blob/devel/tests/builders/test_builders.py
- Created a relative path to stream_examples.yml symlink
|
@Mariamajib Make sure to link your issue to this pull request. |
|
…c' for the compiler search
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1515 +/- ##
==========================================
+ Coverage 77.02% 77.54% +0.51%
==========================================
Files 57 57
Lines 6615 6615
==========================================
+ Hits 5095 5129 +34
+ Misses 1520 1486 -34
☔ View full report in Codecov by Sentry. |
@Mariamajib please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please check the style check the yamllint check is failing. This package should be available if you did pip install -r docs/requirements.txt
. If its set then just simply run yamllint buildtest tests
at the root of directory and fix all the error messages. Ignore the warning. For more details see https://yamllint.readthedocs.io/en/stable/
The tests all ran to completion; however, something I noticed is that coverage was not added to the file specified in the original issue. Instead, Coverage was added to 3 different files as seen here @shahzebsiddiqui What would be the next steps? |
I discovered that the coverage was added to the file specified in the original issue base.py but it was under the indirect changes @shahzebsiddiqui @Mendi03 . Here is the link https://app.codecov.io/gh/buildtesters/buildtest/pull/1515/blob/buildtest/builders/base.py |
You're right! Let's wait and see what @shahzebsiddiqui has to say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mariamajib this looks good. Regression test is passing and i see code coverage is showing up.
Thanks and great work!. Congrats on your 1st contribution