Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming buildtest help to buildtest show #1530

Merged
merged 10 commits into from
Jul 12, 2023

Conversation

Mendi03
Copy link
Collaborator

@Mendi03 Mendi03 commented Jul 10, 2023

Made the following updates:

  • Switched the functionality of buildtest help to buildtest show in order to create new purpose for buildtest help command.
  • Updated documentation
  • test_help.py was changed to test_show.py
  • Instances of buildtest help were changed to buildtest show in the show.py and test_show.py file
  • print_help methods changed to print_show

The buildtest help command is now buildtest show.

Example:
The output for buildtest help build will now be the output buildtest show build
Renamed "help.py" to "show.py" to leave the word "help" free for new feature
@Mendi03 Mendi03 added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Jul 10, 2023
@Mendi03 Mendi03 self-assigned this Jul 10, 2023
@Mendi03 Mendi03 marked this pull request as draft July 10, 2023 18:36
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e111ca3) 77.97% compared to head (c0d7fe0) 77.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1530   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files          57       57           
  Lines        6615     6615           
=======================================
  Hits         5158     5158           
  Misses       1457     1457           
Impacted Files Coverage Δ
buildtest/cli/__init__.py 100.00% <100.00%> (ø)
buildtest/cli/show.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Mendi03 Mendi03 linked an issue Jul 10, 2023 that may be closed by this pull request
5 tasks
@Mendi03 Mendi03 changed the title Work in progress: Adding "buildtest help" feature to display all subcommands Work in progress: Renaming buildtest help to buildtest show Jul 10, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 11, 2023
@Mendi03 Mendi03 marked this pull request as ready for review July 11, 2023 15:03
@Mendi03 Mendi03 changed the title Work in progress: Renaming buildtest help to buildtest show Renaming buildtest help to buildtest show Jul 11, 2023
@shahzebsiddiqui shahzebsiddiqui requested review from braeeast2001 and kingxleyy and removed request for braeeast2001 July 11, 2023 15:41
Copy link
Collaborator

@kingxleyy kingxleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good to me

tests/cli/test_help.py Outdated Show resolved Hide resolved
@shahzebsiddiqui shahzebsiddiqui removed the 🚧 WIP Still work-in-progress, please don't review and don't merge label Jul 11, 2023
changed the name and instances of the method test_buildtest_help to test_buildtest_show and changed buildtest_help to buildtest_show.
Latly, changed file name test_help to test_show.
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 11, 2023
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job @Mendi03

@shahzebsiddiqui shahzebsiddiqui merged commit 2aa87b4 into buildtesters:devel Jul 12, 2023
30 of 31 checks passed
@Mendi03 Mendi03 deleted the help_all branch July 12, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants