Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listing all buildtest config profiles list #1552

Merged
merged 46 commits into from
Aug 7, 2023

Conversation

kingxleyy
Copy link
Collaborator

add a command buildtest config profiles list

@kingxleyy kingxleyy requested a review from Mendi03 July 13, 2023 21:19
@kingxleyy kingxleyy linked an issue Jul 13, 2023 that may be closed by this pull request
8 tasks
@kingxleyy kingxleyy self-assigned this Jul 13, 2023
@kingxleyy kingxleyy marked this pull request as draft July 13, 2023 21:20
@kingxleyy kingxleyy marked this pull request as ready for review July 14, 2023 16:56
bash_completion.sh Outdated Show resolved Hide resolved
bash_completion.sh Outdated Show resolved Hide resolved
@Mendi03 Mendi03 marked this pull request as draft July 14, 2023 17:27
@kingxleyy kingxleyy marked this pull request as ready for review July 16, 2023 17:17
@kingxleyy kingxleyy marked this pull request as draft July 16, 2023 17:17
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 94.44% and no project coverage change.

Comparison is base (8abc678) 78.38% compared to head (c828d11) 78.38%.
Report is 17 commits behind head on devel.

❗ Current head c828d11 differs from pull request most recent head 4701ad1. Consider uploading reports for the commit 4701ad1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1552   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files          57       57           
  Lines        6583     6597   +14     
=======================================
+ Hits         5160     5171   +11     
- Misses       1423     1426    +3     
Files Changed Coverage Δ
buildtest/cli/config.py 87.18% <90.00%> (+0.41%) ⬆️
buildtest/cli/__init__.py 98.22% <100.00%> (+0.02%) ⬆️
buildtest/cli/commands.py 100.00% <100.00%> (ø)
buildtest/cli/show.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…n be called

directly and added method variables theme, print_yaml to configure how profiles can be displayed.
Add regression test for listing profiles and in yaml format
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 27, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 3, 2023
COMPREPLY=( $( compgen -W "${opts}" -- $cur ) )
fi

case "${prev}" in --theme|-t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the -t option this will be removed in #1576

bash_completion.sh Outdated Show resolved Hide resolved
Comment on lines 3 to 6
# specify list of hostnames where buildtest can run for given system record
hostnames: [".*"]

# system description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please dont commit buildtest/settings/config.yml this was a result of running the regression test which autoupdates the file. Don't do git add . or something. Just copy the content from devel branch and paste it in that should avoid showing this commit diff for this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kingxleyy i still see this file ``buildtest/settings/config.yml` in commit diff

bash_completion.sh Outdated Show resolved Hide resolved
bash_completion.sh Outdated Show resolved Hide resolved
@shahzebsiddiqui shahzebsiddiqui merged commit d0aff02 into buildtesters:devel Aug 7, 2023
14 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: list all profiles
3 participants