Fix time calculation for batch jobs #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll be used to determine how long job is run in raw seconds. This will be used when --timeout is specified to cancel job if elapsed time has exceeded timeout value
cancel if elapsed time exceeds test timeout
…completed jobs also update the calcuation for total runtime when its a batch job to use elapsed time
…e this for cancelling job when pendtime exceeds maxpendtime
… in Job class. We use this variable as reference point when job was submitted to calculate pending time using time.time(). This will avoid us from having to query the scheduler for the elapsed pending time. We use this to determine when to cancel job
…ndtime exceeds maxpendtime. These methods are defined in BaseExecutor class which can be invoked in each executor method. Add this implementation for slurm and lsf scheduler to call these methods. round calculation to 2 decimals for calculating elapsedtime and pendtime. also print pendtime and elapsedtime as columns into the table
also fix an issue when using 1 sec poll interval with slurm where sacct can't retrieve the job state. For this we sleep 0.1 sec if job state is not retrieved and retry again.
…ass since there was code that was redundant update the __init__ method for BaseExecutor to take variables account, maxpendtime which can be optionally passed in. These are required for batch executors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.