Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding regression test workflow in container #1635

Merged
merged 47 commits into from
Jun 28, 2024
Merged

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

@Xiangs18
Copy link
Collaborator

@shahzebsiddiqui Regression test is at least running in container now. Still need to debug on failing tests if any.

@shahzebsiddiqui
Copy link
Member Author

Details

@shahzebsiddiqui Regression test is at least running in container now. Still need to debug on failing tests if any.

thanks for getting this running for now, we should try getting checkout to work inside the container. I also merged #1789 which should address issue with tcsh, zsh not being in container. I recently added a PR to install pip automatically #1792

@Xiangs18
Copy link
Collaborator

Xiangs18 commented Jun 26, 2024

Hi @shahzebsiddiqui, I added check repo and now is running as expected. I downgraded from v4 to v3 to avoid version GLIBC_2.28' not found bug.

Still need to fix some failing tests but that is out of scope of this PR. Also why do we need tmate session step?

Let's remove tmate step

@shahzebsiddiqui shahzebsiddiqui merged commit 9d12235 into devel Jun 28, 2024
21 of 24 checks passed
@shahzebsiddiqui shahzebsiddiqui deleted the regtest_container branch June 28, 2024 19:12
@shahzebsiddiqui
Copy link
Member Author

thanks @Xiangs18 for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants