remove executors via command line 'buildtest config executors remove' #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will autocomplete with list of executors that are available to be removed
… executors add option 'buildtest config executors list --all' to list all executors available
add support for removing executors.
…r defined. This will prevent issue during validation where removing an executor leads to no local executors`
2 tasks
add test coverage for listing all executors. fix issue with method invocation for remove_executors
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #1636 +/- ##
==========================================
+ Coverage 78.43% 78.45% +0.03%
==========================================
Files 57 57
Lines 6647 6683 +36
==========================================
+ Hits 5213 5243 +30
- Misses 1434 1440 +6
☔ View full report in Codecov by Sentry. |
…ecutors. add test coverage when there is an invalid executor type and executor name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.