New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete instance + DayOfWeekGroup enum update #172

Merged

bhl09 merged 10 commits into develop from delete_instance

Mar 19, 2020

Contributor

bhl09 commented Feb 23, 2020 •

edited

Loading

Issue No: #108

Event delete instance (and following instances if wanted)
Added note that deleting instance and the following of an event will take time to be synced
Properly retrieves the correct calendar
Removed Custom item from DayOfWeekGroup enum

bhl09 requested a review from nickrandolph

February 23, 2020 22:14

nickrandolph reviewed

View reviewed changes

device_calendar/example/lib/presentation/pages/calendar_event.dart Outdated Show resolved Hide resolved

bhl09 changed the title ~~Delete instance~~ Delete instance + DayOfWeekGroup enum update

bhl09 requested a review from NickBalnaves

March 12, 2020 05:08

nickrandolph reviewed

View reviewed changes

device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

device_calendar/lib/src/common/calendar_enums.dart Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt Outdated Show resolved Hide resolved

nickrandolph reviewed

View reviewed changes

device_calendar/android/src/main/kotlin/com/builttoroam/devicecalendar/CalendarDelegate.kt Outdated Show resolved Hide resolved

bhl09 force-pushed the delete_instance branch from 0fc46a1 to 8d1caab Compare

March 18, 2020 05:02

nickrandolph previously approved these changes

View reviewed changes

bhl09 added 10 commits

March 19, 2020 15:38


          Delete instance added for Android + example app

718e135


          Delete instance added for iOS

d5f08ce


          Added a new dialog for deleting instances

511c5b3

- [Android] delete instance and its following works but retrieving afterwards is broken


          Recurrence delete functional for iOS

faf4b3a


          Delete multiple instances is functional for Android

1c231e5


          Fixed to show snack bar message

a2a200f


          Remove callbacks for pages and use widget

6545f63


          Apply DayOfWeekGroup enum update

b920f2d


          Update CHANGELOG.md

1d9e7f2


          Update loops and search logic

48b0ceb

bhl09 dismissed nickrandolph’s stale review via

48b0ceb

March 19, 2020 04:38

bhl09 force-pushed the delete_instance branch from fea606f to 48b0ceb Compare

March 19, 2020 04:38

nickrandolph approved these changes

View reviewed changes

bhl09 merged commit 16a3f3f into develop

bhl09 deleted the delete_instance branch

March 19, 2020 22:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet