iOS Source fallbacks and re-add url parameter #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andzejsw and @thomassth are you both ok with this PR? |
|
@nickrandolph All looks good. |
|
Will this PR ever be merged? |
|
lmk know if you need anything else from my end to make it happen! |
thomassth
approved these changes
Sep 18, 2021
|
I don't have an iOS device at hand Can someone run this PR on device and see if there's any error popping up In case there is some migration issue from previous versions |
|
If it helps, I've been running this in production with roughly 30k active iOS users for 3 months and haven't been seeing any errors in crashlytics or having any user reports about it. That being said, not all of them use the calendar functionality, and it isn't particularly essential to the app so it's possible that I wouldn't have heard even if something was going wrong. |
Merged
GoldenSoju
pushed a commit
to GoldenSoju/device_calendar
that referenced
this pull request
Oct 25, 2021
…tmckenzie/fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have separated these into two pull requests but I believe they are both worthwhile fixes; if you disagree about the source fallbacks then it would be great if you could at least re-add the url parameter.
In production I'm seeing errors and a failure to create scheduled notifications on many devices, as it seems in more recent iOS versions there is often no local calendar. It would be even better if there were a way to query sources directly from flutter, but that would complicate things and is probably overkill in most cases - I'm going to guess that 99% of users just use the default iCloud calendar.