Feat: v2 embedding

[diegog-sf]

Why: It seems that the V2 embedding was not applied to the plugin file, Just to the manifest.

What: This PR adds support for v2 embedding.

Documentation:

https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration
https://csdcorp.com/blog/coding/handling-permission-requests-in-android-for-flutter-plugins/

Related issues:

#326

[diegog-sf]

@thomassth Thank you for the review, is there something else needed to get this merged?

[diegog-sf]

Hello, @thomassth can you help me getting this merged?

[thomassth]

Was planning to try it once on my app before merging, in case there are some problem migrating from older versions.

But haven't got the time yet. If you have done similar things I think I can just go ahead.

[diegogarciar]

Ok I’ll do more testing on different devices and let you know.
To the ones looking at this conversation, please try testing the PR too and let us know your findings

[cbermudez97]

Hi im trying using this version and ran into a problem. When creating an Attendee the role argument its not required but in the Kotlin code seems to be non null (see code). Im new to plugins so maybe i miss understood something. Hope it helps.

[diegog-sf]

@cbermudez97 I think your problem is unrelated to this pull request, but feel free to open a separate issue.

[diegog-sf]

@thomassth A college has also tested on his device and it's working as expected. I would say its safe to merge it.

[deezaster]

I get this Xcode output and therefore it's not possible to build.

    ../../../.pub-cache/git/device_calendar-2986ddbfd883b8223c009ec8256e34895aa3a7c0/lib/src/models/event.dart:62:12: Error: Duplicated parameter name 'url'.
          this.url,
               ^^^
    ../../../.pub-cache/git/device_calendar-2986ddbfd883b8223c009ec8256e34895aa3a7c0/lib/src/models/event.dart:59:12: Context: Other parameter named 'url'.
          this.url,
               ^^^
    ../../../.pub-cache/git/device_calendar-2986ddbfd883b8223c009ec8256e34895aa3a7c0/lib/src/models/event.dart:62:12: Error: 'url' was already initialized by this constructor.
          this.url,
```

[thomassth]

I get this Xcode output and therefore it's not possible to build.

    ../../../.pub-cache/git/device_calendar-2986ddbfd883b8223c009ec8256e34895aa3a7c0/lib/src/models/event.dart:62:12: Error: Duplicated parameter name 'url'.
          this.url,
               ^^^
    ../../../.pub-cache/git/device_calendar-2986ddbfd883b8223c009ec8256e34895aa3a7c0/lib/src/models/event.dart:59:12: Context: Other parameter named 'url'.
          this.url,
               ^^^
    ../../../.pub-cache/git/device_calendar-2986ddbfd883b8223c009ec8256e34895aa3a7c0/lib/src/models/event.dart:62:12: Error: 'url' was already initialized by this constructor.
          this.url,

This is not related to this PR, but it’s fixed in #336. Although still waiting for other maintainers to review and merge.

We are also looking for new maintainers! Leave a note in #339 if you’re interested.

[Zookey]

I have side-loaded the dev branch with this changes and I have built release Android APK and it can not add events to the calendar anymore. It works fine when I run debug build of the Android app.

[thomassth]

I have side-loaded the dev branch with this changes and I have built release Android APK and it can not add events to the calendar anymore. It works fine when I run debug build of the Android app.

I have just tried it on my own project and it added events just fine.

Also, please open a separate issue as this PR is not related to your topic.

[Zookey]

Thanks, I will test it once more and create a new issue. Have you tested with release APK build, not debug?