Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CI/CD #352

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Updating CI/CD #352

merged 1 commit into from
Nov 12, 2021

Conversation

thomassth
Copy link
Contributor

@thomassth thomassth commented Nov 10, 2021 •
edited
Loading

Continuing #346

  • Don't create github releases if it failed to publish
  • publication test: Added the flutter environment so credentials are reachable

@thomassth thomassth changed the title more fixes Updating CI/CD Nov 12, 2021
sowens-csd
sowens-csd approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@sowens-csd sowens-csd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. The script is pretty readable, nice that I can usually understand what it's doing on a quick review.

@thomassth thomassth merged commit fb3496a into builttoroam:develop Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowens-csd sowens-csd sowens-csd approved these changes

@andzejsw andzejsw Awaiting requested review from andzejsw

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomassth @sowens-csd