-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android recurring events, edit single instance #428
base: develop
Are you sure you want to change the base?
Android recurring events, edit single instance #428
Conversation
Co-authored-by: Jakub Janiec <jakubjaniec@aol.com>
…rDelegate.kt Co-authored-by: amaterek <arkadiusz.materek@droidsonroids.pl>
Does anything further need to be done in order to have this reviewed/merged? |
Sorry got a lot on my plate right now It looks good, but I think we also need tests I might have some free time next week, or if it works in demo I can approve it |
Thanks for getting back to me Thomas! |
I have doubts on the interoperability. Changing a single event in Google calendar does not reflect on originalInstanceTime. Perhaps they are using other values? |
Also it seems that your branch does not allow maintainers to add commits. If you can't modify access on the branch, I can send it to you. |
Acutally it looks like PR #435 accomplishes this and more. It may be better to focus on that PR since it includes other enhacements as well. |
#435 cramped too many thing into a single commit, and it is too difficult for anyone to check against. Instead, I'd prefer using this, and if 435 has better approach on this specific issue, incorporate that here |
No description provided.