-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy, more session control #278
Conversation
steampy/client.py
Outdated
if proxy_status is True: | ||
self._session.proxies.update(proxies) | ||
|
||
self.steam_guard = guard.load_steam_guard(steam_guard) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like it readed here, it is loaded in login function and thus SteamClient can be used for some cases with API key and without guard. Guard can be hard to obtain so this is braking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Please make 1 commit out of all those changes so in any case it is easily to revert it. |
Okay |
I have a small problem with rebasing it with 1 commit onto current master, I will try to deal with it next week and make new version 0.92 of steampy when it is ready. |
Ok merged it manually with master, closing this. Autologout variable was delete, if you dont want to log out, just dont use with statement. |
Changes:
them
Example:
Session Control:
Also i add option
autologout
in__init__
function for more session control.When
autologout
is True, session will be ended with program endWhen
autologout
is False, session will be not end and you may re-use cookies laterNow you can save session cookies and re-use it later.
re-use example: