New auth pattern #303
New auth pattern #303
Conversation
patch by nbordin
|
I will test it and review today, thanks! |
| @staticmethod | ||
| def _create_cookie(name: str, cookie: str, domain: str) -> dict: | ||
| return {"name": name, | ||
| "value": cookie, | ||
| "domain": domain} | ||
|
|
||
| def _fetch_rsa_params(self, current_number_of_repetitions: int = 0) -> dict: | ||
| self.session.post(SteamUrl.COMMUNITY_URL) |
There was a problem hiding this comment.
why this post, it seems to be doing nothing
There was a problem hiding this comment.
This is required for the initialization of the session with which we will work.
steampy/login.py
Outdated
| self.session.cookies.set(**community_cookie) | ||
| self.session.cookies.set(**store_cookie) | ||
|
|
||
| @staticmethod | ||
| def _create_cookie(name: str, cookie: str, domain: str) -> dict: |
steampy/login.py
Outdated
|
|
||
| def _fetch_home_page(self, session: Session) -> Response: | ||
| return session.post(SteamUrl.COMMUNITY_URL + '/my/home/') | ||
|
|
||
| def _update_steam_guard(self, login_response: Response) -> bool: |
There was a problem hiding this comment.
should return None as it just changes internal state, and we never use its value if it is ok
steampy/login.py
Outdated
| else: | ||
| raise Exception('Cannot update steam guard') | ||
|
|
||
| def _pool_sessions_steam(self, client_id, request_id): |
steampy/login.py
Outdated
| response = self._api_call('POST', 'IAuthenticationService', 'PollAuthSessionStatus', params = pool_data) | ||
| self.refresh_token = response.json()["response"]["refresh_token"] | ||
|
|
||
| def _finallize_login(self): |
There was a problem hiding this comment.
add return type and fix typo, should be _finalize_login
steampy/login.py
Outdated
| sessionid = self.session.cookies["sessionid"] | ||
| redir = "https://steamcommunity.com/login/home/?goto=" | ||
|
|
||
| finallez_data = { |
steampy/login.py
Outdated
|
|
||
| def _finallize_login(self): | ||
| sessionid = self.session.cookies["sessionid"] | ||
| redir = "https://steamcommunity.com/login/home/?goto=" |
There was a problem hiding this comment.
change variable name to be more descriptive and use COMMUNITY_URL
|
Please resolve the comments Also if you can research the logout method, I was able to pass login test, but logout was unsucesfull. I can merge this without logout working but it will be probably next complain. |
patch by nbordin fixed
I've never used the Logout function all these years. P.S. Taking this opportunity, I'd like to thank you for this wonderful project! |
Tested login and inventory.