Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: html element should have a lang attribute #111

Closed
olbrich opened this issue Feb 16, 2023 · 0 comments · Fixed by #497
Closed

Accessibility: html element should have a lang attribute #111

olbrich opened this issue Feb 16, 2023 · 0 comments · Fixed by #497

Comments

@olbrich
Copy link
Contributor

olbrich commented Feb 16, 2023

bullet_train-core/bullet_train-themes-light/app/views/themes/light/layouts/_account.html.erb

Line 2 in f87143f

<html class="theme-<%= BulletTrain::Themes::Light.color %> <%= "theme-secondary-#{BulletTrain::Themes::Light.secondary_color}" if BulletTrain::Themes::Light.secondary_color %>">

According to accessibility standards, the html element should have a lang attribute with the appropriate language code.

Probably we can just add lang="<%= I18n.locale %>" to the html element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accessibility: Add lang attribute to opening html tags bullet-train-co/bullet_train-core
1 participant
@olbrich