Fix clean theme rake task #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagthedrummer
force-pushed
the
fixes/clean-theme
branch
from
ea07e63 to
104e8ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a tough one. A lot changed with
bullet_train-core, so I had to specify the threethemesgems we use, and since we're pulling files from different places, I tried my best to make it as dynamic as possible.I'll still have to look into the
publishtask as well, but we're not getting thetailwind.mailer.light.config.jsfile ejected when running the eject command for some reason (See #26). The file exists inbullet_train-core, but it's not in the gem when downloaded from rubygems.org.Besides that this one should be good to go, but if there's anything that seems off, I'd be glad to look over the code again.