Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LoadsAndAuthorizesResource #508

Merged

Conversation

jagthedrummer
Copy link
Contributor

@jagthedrummer jagthedrummer commented Aug 31, 2023

Picking up #263 to get it over the finish line.

This PR does the following:

  1. Namespaces LoadsAndAuthorizesResource to BulletTrain::LoadsAndAuthorizesResource. This will allow client apps to reference the module still if their app also defines LoadsAndAuthorizesResource.
  2. Maintains backward compatibility by still defining LoadsAndAuthorizesResource and having it include BulletTrain::LoadsAndAuthorizesResource.
  3. Gets rid of the included block, as it was unnecessary.
  4. Wraps class methods in a class_methods block and removes self.

Thanks to @aaricpittman for doing all the heavy lifting on this one. I just had to make a few tiny changes to make the linter happy.

@jagthedrummer jagthedrummer changed the title Aaricpittman/namespace loads and authorizes ressource Refactor LoadsAndAuthorizesResource Aug 31, 2023
@jagthedrummer jagthedrummer merged commit 0b2730f into main Aug 31, 2023
1 check passed
@jagthedrummer jagthedrummer deleted the aaricpittman/namespace-loads_and_authorizes_ressource branch August 31, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants