Bullet Train Update: 1.7.9 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables (#1417) * Update tailwind, switch to tailwindcss/nesting, move postcss-css-variables Fixes #1416 Fixes #1074 As noted in #1416 there's been a change in `tailwindcss` around the `@apply` directive. In order to get it to work correctly for nested classes we need to use the `tailswindcss/nesting` plugin. We were already using `postcss-nested`, which is what `tailwindcss/nesting` uses under the hood. So this PR just switches them out. It also moves the `postcss-css-variables` plugin to be higher in the plugin stack for the mailer stylesheet. [That plugin doesn't play nicely when it's below the nesting plugin.](MadLittleMods/postcss-css-variables#135 (comment)) Moving `postcss-css-variables` higher in the stack also seems to have fixed the problems described in #1074. When it's higher in the stack I see almost zero difference in build times between having it activated or not, and the resulting stylesheet is actually _smaller_ when it is activated (~120k vs ~140k). * Add a link to a report about variable support in email clients
Co-authored-by: Yuri Sidorov <403994+newstler@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
* yarn set version berry * yarn install * corepack enable * try to get yarn to install * cmon yarn * move that into the link-core-gems action
* what version of yarn is this action ending up with? * hmmm * apparently 'upgrade' is now just 'up'?
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
* Update gitpod.Dockerfile to ruby version 3.3.0 * Update gitpod.Dockerfile to ruby 3.3.1
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
…nv var is missing (#1494) * Prevent Knapsack Pro from failing if the KNAPSACK_PRO_CI_NODE_INDEX env var is missing Starting with verison `7.5.0` Knapsack Pro has begun to raise an error if it's missing the environment variables that tell it how to split tests. <https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#750> That change has prevented `depfu` from being able to upgrade us to `7.5.0`. <https://github.com/bullet-train-co/bullet_train/pull/1493/checks?sha=563a3f0035beb0d929d33f2973a308d715222fec> This makes it so that we don't automatically require Knapsack Pro if those env vars are missing. (For "internal" purposes we don't use Knapsack at all, instead we use a crude splitting method to distribute tests across multiple runners on GitHub Actions. We also ship that same GHA workflow when people start a new repo.) * dang linter
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
# Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the Bullet Train Starter Repo to version
1.7.9Please note: You should thorougly review this PR.
🎉 There are no conflicts detected in this PR!