Bullet Train Update: 1.7.23 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bullet-train-co/bullet_train#1663 We shouldn't replace the whole Rails' app's RouteSet, particularly when the `@routes` instance variable already provides the hook. Instead we can mirror what Rails does internally: https://github.com/rails/rails/blob/a59ddc714fa0403cbd8c7ae6abdec2f71ee7b63f/actionpack/test/controller/test_case_test.rb#L1224C1-L1236C8
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
…705) * select2_select_selenium testing: allow a field label to be wrapped in a div * find_stimulus_controller_for_label: allow label to have a wrapper div * invitation_lists_test: avoid sibling to find input * find_stimulus_controller_for_label: it hurts to do this, but go one parent up * find_stimulus_controller_for_label: use ancestor and simplify if not expecting wrapper match * fix standardrb * find_stimulus_controller_for_label: revert to old xpath for going up two parents
* Update gitpod.Dockerfile - Move to Ruby 3.3.4 - add graphviz as a package to install as it is missing on db migration * Update .gitpod.yml Make rails init code work seamlessly with gitpod
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
# Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the Bullet Train Starter Repo to version
1.7.23Please note: You should thorougly review this PR.
🎉 There are no conflicts detected in this PR!