Bullet Train Update: 1.8.1 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rb` (#1726) Hopefully this will reduce confusion around this file. Fixes: bullet-train-co/bullet_train#941
The "deploy to X" buttons rely on the target repo being publicly accessible which seems to be rare. So including these buttons tends to only create confusion and doesn't make anything smoother. Removing them will prevent people from turning down this dead end. I'll update the "deploy to heroku" docs to contain more info about how to deploy a new app. Fixes: bullet-train-co/bullet_train#1609
…)" (#1728) This reverts commit 9df62a6.
The button needs to point at `www.heroku.com/deploy` not just `heroku.com/deploy` for it to even start to work. Once you get past the first step it seems like having boolean literals in the `value` field causes problems (which are hard to debug because Heroku doesn't surface a useful error message). Fixes: bullet-train-co/bullet_train#1609
* Make setup_github bool a global variable * Calculate new repo link from ssh path in configure script * Fix regex in setup github script
We used to provision higher production-ready tiers of the addons and when we updated `app.json` to provision demo-ready tiers we forgot to update the estimated cost of the addons.
This makes it so that you can run either of these scripts independently of `bin/configure`: * `./bin/configure-scripts/deploy_button_heroku.rb` * `./bin/configure-scripts/deploy_button_render.rb`
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
# Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the Bullet Train Starter Repo to version
1.8.1Please note: You should thorougly review this PR.
🎉 There are no conflicts detected in this PR!