Bullet Train Update: 1.9.0 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set `config.raise_on_missing_callback_actions = true` This is a new config in Rails 7.1 and the default is to have it set to `true` in `development` and `test` environments. * what if we include these here instead of in the base concern * trying to get it working with these being defined in the core repo * got these working from the core repo * Remove custom configs
When using `def setup` things can behave unpredictably if developers forget to call `super`. Using the `setup do` callback form eliminates that problem. Fixes: bullet-train-co/bullet_train#1626
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
…e (#1739) * Make it easier to use Cloudinary as a storage option for ActiveStorage This makes it easier to use Cloudindary as the backend service for ActiveStorage. From a functional perspective this works very much like the S3 service option. ActiveStorage is still in control of files, but it sends them through to Cloudinary for storage and delivery. **NOTE:** If, in production, you use Cloudinary for anything and have a `CLOUDINARY_URL` ENV var set but you want to use the `:local` option for ActiveStorage then you'll want to make an adjustment to `config/environments/production.rb`. Partial fix for : bullet-train-co/bullet_train#1617
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
Fixes: bullet-train-co/bullet_train#1587 The issues that this monkey patch was for was fixed upstream in rails via this PR: rails/rails#52281
* Add script to check for image processing deps - vips - imagemagick * Run standard
…geMagick (#1765) * Refactor check_image_dependencies.rb to not require both vips and ImageMagick This makes it so that if you have either `vips` or `magick` available on your `PATH` that we count that as being good enough for image processing dependencies and we move on. Previously we'd check for both and prompt you to install both even though we only need one or the other. This should make it less confusing for people who don't realize that they're alternatives that do the same thing. * linter
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
* Rely on the version of pagy specified by the core gems * Fix the pagination test to match the new pagy default * CI doesn't seem to find >...
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: jagthedrummer <jagthedrummer@users.noreply.github.com>
# Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the Bullet Train Starter Repo to version
1.9.0Please note: You should thorougly review this PR.
🎉 There are no conflicts detected in this PR!