Skip to content

Commit

Permalink
Avoid buggy versions of factory_bot_rails (#1173)
Browse files Browse the repository at this point in the history
* Avoid buggy versions of factory_bot_rails

There's a bug in the latest version of `factory_bot_rails`:
thoughtbot/factory_bot_rails#433

There's also a fix that hasn't been merged or released yet:
thoughtbot/factory_bot_rails#432

I'm setting the `Gemfile` to specifically avoid those buggy versions so
that we can get `depfu` un-blocked with keeping gems up to date.

* dang linter
  • Loading branch information
jagthedrummer authored Nov 21, 2023
1 parent 8445e74 commit f07e2c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ group :development, :test do
gem "simplecov", require: false

# Generate test objects.
gem "factory_bot_rails"
# 6.3.0 and 6.4.0 have a bug https://github.com/thoughtbot/factory_bot_rails/issues/433
gem "factory_bot_rails", "~> 6.2", "!= 6.3.0", "!= 6.4.0"
end

group :development do
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ DEPENDENCIES
debug
devise
devise-two-factor
factory_bot_rails
factory_bot_rails (~> 6.2, != 6.4.0, != 6.3.0)
foreman
honeybadger
jbuilder
Expand Down

0 comments on commit f07e2c1

Please sign in to comment.