-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Devcontainer Support #1620
base: main
Are you sure you want to change the base?
Add Devcontainer Support #1620
Conversation
Hey, @aroop, thanks for the PR! I don't use VSC so I'm not really equipped to give this a full review. I'm going to ping some of the other folks on the core team and see if one of them can give it a run. |
Hey @aroop, this looks great! I like the idea of running the app in a docker container this way. A couple things:
However, when I open VS Code and try to reopen it with the container, I get a permission denied error: "remoteUser": "gazayas",
"containerUser": "gazayas" No luck here either. I also tried changing the VS Code profile from Default to gazayas, to no avail. Anything I'm missing? Either way, I do like the idea and think adding it to the project would be really helpful! |
# Use "forwardPorts" in **devcontainer.json** to forward an app port locally. | ||
# (Adding the "ports" property to this file will not forward from a Codespace.) | ||
ports: | ||
- 45678:45678 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose adding an env variable to improve the corepack prompt on the install process
environment:
COREPACK_ENABLE_DOWNLOAD_PROMPT: 0 # prevent yarn install y/n prompt
Description
This PR adds support for Devcontainers to streamline the development environment setup process using Visual Studio Code. With this update, developers can easily configure and launch the project within a containerized environment, ensuring consistency across different development setups.
Changes
bin/setup-devcontainer
which does not install Postgres and Redis as they are available as servicesInstructions to Test
git clone git@github.com:bullet-train-co/bullet_train.git your_new_project_name
cd your_new_project_name
./bin/configure
Open in VS Code:
This setup ensures a consistent development environment and simplifies new project setup