Use load hooks for monkey_patch loading #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport.on_load(:action_view)
is technically how we're supposedto extend ActionView::Base and other Action View classes, but we weren't
doing that for our monkey patches.
We could add a
ActiveSupport.on_load(:action_view)
load hook for eachextension, but it feels cleaner to let the top level file handle that
set up.
This then also moves the helper require to the same place for parity.