Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bullets.vim breaks <CR> mappings from other plugins #43

Open
nkakouros opened this issue Feb 1, 2020 · 2 comments
Open

Bullets.vim breaks <CR> mappings from other plugins #43

nkakouros opened this issue Feb 1, 2020 · 2 comments

Comments

@nkakouros
Copy link

nkakouros commented Feb 1, 2020

I have the following plugins enabled:

ncm2
ncm2-ultisnips
ncm2-markdown-subscope
ultisnips
bullets.vim

When a fenced code block editing a markdown file, eg python, ncm2 provides completions some of which are snippets. When I select a snippet in the popup menu and hit Enter, I normally expect the snippet to expand. However, with bullets.vim enabled, the expansion does not happen.

Other plugins like endwise and autopairs append their mapping to the user's <CR> mapping.

I also tried to disable the <CR> mapping of bullets.vim and call some function from the plugin to trigger list completion, but the functions are not available as they are script local.

@dkarter
Copy link
Member

dkarter commented May 5, 2020

@nkakouros would you be interested in opening a PR to fix that?

@mawkler
Copy link

mawkler commented Feb 26, 2021

I have the same issue with bullet.vim and vim-clap. Pressing <cr> to select an item with vim-clap does nothing when bullet.vim is installed. Adding let g:bullets_set_mappings = 0, or removing bullets.vim solves the issue, which is why I'm suspecting the <cr> mapping.

To reproduce:

  1. .vimrc:

    call plug#begin('~/.config/nvim/plugged')
    Plug 'liuchengxu/vim-clap'
    Plug 'dkarter/bullets.vim'
    call plug#end()
  2. :Clap files

  3. Press <cr> on any match. Nothing happens.

mmrwoods added a commit to mmrwoods/dotfiles that referenced this issue Dec 28, 2021
Rework insert mode cr mapping to accept completion if menu visible

See bullets-vim/bullets.vim#43
And bullets-vim/bullets.vim#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants