sidebar: genericize the component and add improvements #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Merged
fbraure
reviewed
Aug 30, 2024
| @@ -1,5 +1,5 @@ | |||
| layout: help | |||
| sidebar: true | |||
| page_class: help | |||
| page_class: help with-sidebar | |||
There was a problem hiding this comment.
I'm sorry I'm not familiar with this can you explain what is it for?
There was a problem hiding this comment.
These are css classes that will be applied to the body of all the pages contained in the same folder as _defaults.yml
fbraure
reviewed
Aug 30, 2024
thimy
force-pushed
the
genericize-sidebar
branch
from
2ddd191 to
c736506
Compare
fbraure
approved these changes
Sep 2, 2024
| @@ -1,5 +1,5 @@ | |||
| layout: help | |||
| sidebar: true | |||
| page_class: help | |||
| page_class: help with-sidebar | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidebar is currently under the
Helpnamespace but we will need it for the upcoming guides so I'm putting it underShared.In the mean time I also improve some accessibility and responsive stuff.