Skip to content

Commit

Permalink
Deprecate .thumnbail(float) and javadoc RequestListener and thumbnail…
Browse files Browse the repository at this point in the history 
… behavior.

PiperOrigin-RevId: 396424687
  • Loading branch information
@sjudd @glide-copybara-robot
sjudd authored and glide-copybara-robot committed Sep 13, 2021
1 parent e7fe3e3 commit aa23eed
Show file tree
Hide file tree
Showing 9 changed files with 168 additions and 47 deletions.
16 changes: 11 additions & 5 deletions annotation/compiler/test/src/test/resources/EmptyAppGlideModuleTest/GlideRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ public GlideRequest<TranscodeType> transform(@NonNull Transformation<Bitmap>...
"unchecked",
"varargs"
})
public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>... transformations) {
public GlideRequest<TranscodeType> transforms(
@NonNull Transformation<Bitmap>... transformations) {
return (GlideRequest<TranscodeType>) super.transforms(transformations);
}

Expand All @@ -408,7 +409,8 @@ public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>...
*/
@NonNull
@CheckResult
public GlideRequest<TranscodeType> optionalTransform(@NonNull Transformation<Bitmap> transformation) {
public GlideRequest<TranscodeType> optionalTransform(
@NonNull Transformation<Bitmap> transformation) {
return (GlideRequest<TranscodeType>) super.optionalTransform(transformation);
}

Expand Down Expand Up @@ -476,7 +478,8 @@ public GlideRequest<TranscodeType> apply(@NonNull BaseRequestOptions<?> options)
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> transition(@NonNull TransitionOptions<?, ? super TranscodeType> options) {
public GlideRequest<TranscodeType> transition(
@NonNull TransitionOptions<?, ? super TranscodeType> options) {
return (GlideRequest<TranscodeType>) super.transition(options);
}

Expand All @@ -490,7 +493,8 @@ public GlideRequest<TranscodeType> listener(@Nullable RequestListener<TranscodeT
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> addListener(@Nullable RequestListener<TranscodeType> listener) {
public GlideRequest<TranscodeType> addListener(
@Nullable RequestListener<TranscodeType> listener) {
return (GlideRequest<TranscodeType>) super.addListener(listener);
}

Expand Down Expand Up @@ -519,7 +523,8 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeT
@CheckResult
@SafeVarargs
@SuppressWarnings("varargs")
public final GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeType>... builders) {
public final GlideRequest<TranscodeType> thumbnail(
@Nullable RequestBuilder<TranscodeType>... builders) {
return (GlideRequest<TranscodeType>) super.thumbnail(builders);
}

Expand All @@ -531,6 +536,7 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable List<RequestBuilder<Trans
}

@Override
@Deprecated
@NonNull
@CheckResult
public GlideRequest<TranscodeType> thumbnail(float sizeMultiplier) {
Expand Down
16 changes: 11 additions & 5 deletions ...r/test/src/test/resources/GlideExtensionOptionsTest/MemoizeStaticMethod/GlideRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ public GlideRequest<TranscodeType> transform(@NonNull Transformation<Bitmap>...
"unchecked",
"varargs"
})
public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>... transformations) {
public GlideRequest<TranscodeType> transforms(
@NonNull Transformation<Bitmap>... transformations) {
return (GlideRequest<TranscodeType>) super.transforms(transformations);
}

Expand All @@ -408,7 +409,8 @@ public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>...
*/
@NonNull
@CheckResult
public GlideRequest<TranscodeType> optionalTransform(@NonNull Transformation<Bitmap> transformation) {
public GlideRequest<TranscodeType> optionalTransform(
@NonNull Transformation<Bitmap> transformation) {
return (GlideRequest<TranscodeType>) super.optionalTransform(transformation);
}

Expand Down Expand Up @@ -476,7 +478,8 @@ public GlideRequest<TranscodeType> apply(@NonNull BaseRequestOptions<?> options)
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> transition(@NonNull TransitionOptions<?, ? super TranscodeType> options) {
public GlideRequest<TranscodeType> transition(
@NonNull TransitionOptions<?, ? super TranscodeType> options) {
return (GlideRequest<TranscodeType>) super.transition(options);
}

Expand All @@ -490,7 +493,8 @@ public GlideRequest<TranscodeType> listener(@Nullable RequestListener<TranscodeT
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> addListener(@Nullable RequestListener<TranscodeType> listener) {
public GlideRequest<TranscodeType> addListener(
@Nullable RequestListener<TranscodeType> listener) {
return (GlideRequest<TranscodeType>) super.addListener(listener);
}

Expand Down Expand Up @@ -519,7 +523,8 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeT
@CheckResult
@SafeVarargs
@SuppressWarnings("varargs")
public final GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeType>... builders) {
public final GlideRequest<TranscodeType> thumbnail(
@Nullable RequestBuilder<TranscodeType>... builders) {
return (GlideRequest<TranscodeType>) super.thumbnail(builders);
}

Expand All @@ -531,6 +536,7 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable List<RequestBuilder<Trans
}

@Override
@Deprecated
@NonNull
@CheckResult
public GlideRequest<TranscodeType> thumbnail(float sizeMultiplier) {
Expand Down
16 changes: 11 additions & 5 deletions ...mpiler/test/src/test/resources/GlideExtensionOptionsTest/OverrideExtend/GlideRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ public GlideRequest<TranscodeType> transform(@NonNull Transformation<Bitmap>...
"unchecked",
"varargs"
})
public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>... transformations) {
public GlideRequest<TranscodeType> transforms(
@NonNull Transformation<Bitmap>... transformations) {
return (GlideRequest<TranscodeType>) super.transforms(transformations);
}

Expand All @@ -399,7 +400,8 @@ public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>...
*/
@NonNull
@CheckResult
public GlideRequest<TranscodeType> optionalTransform(@NonNull Transformation<Bitmap> transformation) {
public GlideRequest<TranscodeType> optionalTransform(
@NonNull Transformation<Bitmap> transformation) {
return (GlideRequest<TranscodeType>) super.optionalTransform(transformation);
}

Expand Down Expand Up @@ -467,7 +469,8 @@ public GlideRequest<TranscodeType> apply(@NonNull BaseRequestOptions<?> options)
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> transition(@NonNull TransitionOptions<?, ? super TranscodeType> options) {
public GlideRequest<TranscodeType> transition(
@NonNull TransitionOptions<?, ? super TranscodeType> options) {
return (GlideRequest<TranscodeType>) super.transition(options);
}

Expand All @@ -481,7 +484,8 @@ public GlideRequest<TranscodeType> listener(@Nullable RequestListener<TranscodeT
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> addListener(@Nullable RequestListener<TranscodeType> listener) {
public GlideRequest<TranscodeType> addListener(
@Nullable RequestListener<TranscodeType> listener) {
return (GlideRequest<TranscodeType>) super.addListener(listener);
}

Expand Down Expand Up @@ -510,7 +514,8 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeT
@CheckResult
@SafeVarargs
@SuppressWarnings("varargs")
public final GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeType>... builders) {
public final GlideRequest<TranscodeType> thumbnail(
@Nullable RequestBuilder<TranscodeType>... builders) {
return (GlideRequest<TranscodeType>) super.thumbnail(builders);
}

Expand All @@ -522,6 +527,7 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable List<RequestBuilder<Trans
}

@Override
@Deprecated
@NonNull
@CheckResult
public GlideRequest<TranscodeType> thumbnail(float sizeMultiplier) {
Expand Down
16 changes: 11 additions & 5 deletions ...est/resources/GlideExtensionOptionsTest/OverrideExtendMultipleArguments/GlideRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ public GlideRequest<TranscodeType> transform(@NonNull Transformation<Bitmap>...
"unchecked",
"varargs"
})
public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>... transformations) {
public GlideRequest<TranscodeType> transforms(
@NonNull Transformation<Bitmap>... transformations) {
return (GlideRequest<TranscodeType>) super.transforms(transformations);
}

Expand All @@ -399,7 +400,8 @@ public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>...
*/
@NonNull
@CheckResult
public GlideRequest<TranscodeType> optionalTransform(@NonNull Transformation<Bitmap> transformation) {
public GlideRequest<TranscodeType> optionalTransform(
@NonNull Transformation<Bitmap> transformation) {
return (GlideRequest<TranscodeType>) super.optionalTransform(transformation);
}

Expand Down Expand Up @@ -467,7 +469,8 @@ public GlideRequest<TranscodeType> apply(@NonNull BaseRequestOptions<?> options)
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> transition(@NonNull TransitionOptions<?, ? super TranscodeType> options) {
public GlideRequest<TranscodeType> transition(
@NonNull TransitionOptions<?, ? super TranscodeType> options) {
return (GlideRequest<TranscodeType>) super.transition(options);
}

Expand All @@ -481,7 +484,8 @@ public GlideRequest<TranscodeType> listener(@Nullable RequestListener<TranscodeT
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> addListener(@Nullable RequestListener<TranscodeType> listener) {
public GlideRequest<TranscodeType> addListener(
@Nullable RequestListener<TranscodeType> listener) {
return (GlideRequest<TranscodeType>) super.addListener(listener);
}

Expand Down Expand Up @@ -510,7 +514,8 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeT
@CheckResult
@SafeVarargs
@SuppressWarnings("varargs")
public final GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeType>... builders) {
public final GlideRequest<TranscodeType> thumbnail(
@Nullable RequestBuilder<TranscodeType>... builders) {
return (GlideRequest<TranscodeType>) super.thumbnail(builders);
}

Expand All @@ -522,6 +527,7 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable List<RequestBuilder<Trans
}

@Override
@Deprecated
@NonNull
@CheckResult
public GlideRequest<TranscodeType> thumbnail(float sizeMultiplier) {
Expand Down
16 changes: 11 additions & 5 deletions ...piler/test/src/test/resources/GlideExtensionOptionsTest/OverrideReplace/GlideRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ public GlideRequest<TranscodeType> transform(@NonNull Transformation<Bitmap>...
"unchecked",
"varargs"
})
public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>... transformations) {
public GlideRequest<TranscodeType> transforms(
@NonNull Transformation<Bitmap>... transformations) {
return (GlideRequest<TranscodeType>) super.transforms(transformations);
}

Expand All @@ -399,7 +400,8 @@ public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>...
*/
@NonNull
@CheckResult
public GlideRequest<TranscodeType> optionalTransform(@NonNull Transformation<Bitmap> transformation) {
public GlideRequest<TranscodeType> optionalTransform(
@NonNull Transformation<Bitmap> transformation) {
return (GlideRequest<TranscodeType>) super.optionalTransform(transformation);
}

Expand Down Expand Up @@ -467,7 +469,8 @@ public GlideRequest<TranscodeType> apply(@NonNull BaseRequestOptions<?> options)
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> transition(@NonNull TransitionOptions<?, ? super TranscodeType> options) {
public GlideRequest<TranscodeType> transition(
@NonNull TransitionOptions<?, ? super TranscodeType> options) {
return (GlideRequest<TranscodeType>) super.transition(options);
}

Expand All @@ -481,7 +484,8 @@ public GlideRequest<TranscodeType> listener(@Nullable RequestListener<TranscodeT
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> addListener(@Nullable RequestListener<TranscodeType> listener) {
public GlideRequest<TranscodeType> addListener(
@Nullable RequestListener<TranscodeType> listener) {
return (GlideRequest<TranscodeType>) super.addListener(listener);
}

Expand Down Expand Up @@ -510,7 +514,8 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeT
@CheckResult
@SafeVarargs
@SuppressWarnings("varargs")
public final GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeType>... builders) {
public final GlideRequest<TranscodeType> thumbnail(
@Nullable RequestBuilder<TranscodeType>... builders) {
return (GlideRequest<TranscodeType>) super.thumbnail(builders);
}

Expand All @@ -522,6 +527,7 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable List<RequestBuilder<Trans
}

@Override
@Deprecated
@NonNull
@CheckResult
public GlideRequest<TranscodeType> thumbnail(float sizeMultiplier) {
Expand Down
16 changes: 11 additions & 5 deletions ...iler/test/src/test/resources/GlideExtensionOptionsTest/SkipStaticMethod/GlideRequest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ public GlideRequest<TranscodeType> transform(@NonNull Transformation<Bitmap>...
"unchecked",
"varargs"
})
public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>... transformations) {
public GlideRequest<TranscodeType> transforms(
@NonNull Transformation<Bitmap>... transformations) {
return (GlideRequest<TranscodeType>) super.transforms(transformations);
}

Expand All @@ -408,7 +409,8 @@ public GlideRequest<TranscodeType> transforms(@NonNull Transformation<Bitmap>...
*/
@NonNull
@CheckResult
public GlideRequest<TranscodeType> optionalTransform(@NonNull Transformation<Bitmap> transformation) {
public GlideRequest<TranscodeType> optionalTransform(
@NonNull Transformation<Bitmap> transformation) {
return (GlideRequest<TranscodeType>) super.optionalTransform(transformation);
}

Expand Down Expand Up @@ -476,7 +478,8 @@ public GlideRequest<TranscodeType> apply(@NonNull BaseRequestOptions<?> options)
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> transition(@NonNull TransitionOptions<?, ? super TranscodeType> options) {
public GlideRequest<TranscodeType> transition(
@NonNull TransitionOptions<?, ? super TranscodeType> options) {
return (GlideRequest<TranscodeType>) super.transition(options);
}

Expand All @@ -490,7 +493,8 @@ public GlideRequest<TranscodeType> listener(@Nullable RequestListener<TranscodeT
@Override
@NonNull
@CheckResult
public GlideRequest<TranscodeType> addListener(@Nullable RequestListener<TranscodeType> listener) {
public GlideRequest<TranscodeType> addListener(
@Nullable RequestListener<TranscodeType> listener) {
return (GlideRequest<TranscodeType>) super.addListener(listener);
}

Expand Down Expand Up @@ -519,7 +523,8 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeT
@CheckResult
@SafeVarargs
@SuppressWarnings("varargs")
public final GlideRequest<TranscodeType> thumbnail(@Nullable RequestBuilder<TranscodeType>... builders) {
public final GlideRequest<TranscodeType> thumbnail(
@Nullable RequestBuilder<TranscodeType>... builders) {
return (GlideRequest<TranscodeType>) super.thumbnail(builders);
}

Expand All @@ -531,6 +536,7 @@ public GlideRequest<TranscodeType> thumbnail(@Nullable List<RequestBuilder<Trans
}

@Override
@Deprecated
@NonNull
@CheckResult
public GlideRequest<TranscodeType> thumbnail(float sizeMultiplier) {
Expand Down
Loading

0 comments on commit aa23eed

Please sign in to comment.