[Question] Is this the best way to download an image to share?

[jt-gilkeson]

Glide Version: 4.8.0

Integration libraries:OkHttp3 3.10.0

Issue details / Repro steps / Use case background:
I'm implementing a "Share photo" feature in my app, but I'm having trouble figuring out the "right" / most efficient way to do it with Glide v4. Basically if a user selects a scaled down "preview" image (view) and hits share, I want to give glide a URL, download the fullsize image contents, save it out to the cacheDir, and put it in a sharing intent. I've seen older examples (v3) with toBytes() and other things that seem more efficient than what I am doing, but I don't see how to do this with v4 - also SimpleTraget is warning me about being deprecated. Basically my question is what is the best way to do this and make sure I clean things up when I'm done with the bitmap / request?

override fun sharePostcard(url: String) {
   Glide.with(this).asBitmap().load(url).into(object: SimpleTarget<Bitmap>() {
      override fun onResourceReady(resource: Bitmap, transition: Transition<in Bitmap>?) {
        // Build the message
        val imageUri = getShareImageUri(this@MyActivity, resource)

        // Is this needed to clean things up?  (and is this the right way to do it)
        someView.post {
          Glide.with(this@MyActivity).clear(this)
        }

        // Code below included for completeness -getShareIntent to relevant to Glide usage
        val sharingIntent = ShareImageHelper.getShareIntent(subject, body, imageUri)

        startActivity(
          Intent.createChooser(
            sharingIntent,
            localizationManager.getLocalizedString(R.string.shareusing)
          )
       )
    }
  })
}  

/**
 * Creates a file and gets a Uri for sharing an image
 */
fun getShareImageUri(context: Context, image: Bitmap): Uri? {
    val path = File(context.cacheDir, IMAGE_SHARE_PREFIX + Date().time + JPG_EXTENSION)

    try {
        val fileOutputStream = FileOutputStream(path)
        image.compress(Bitmap.CompressFormat.JPEG, 100, fileOutputStream)
        fileOutputStream.close()
    } catch (e: IOException) {
        return null
    }

    return getUriForFile(context, path)
}

/**
 * Gets a Uri for file
 */
 fun getUriForFile(context: Context, file: File): Uri {
    return if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.M) {
        Uri.fromFile(file)
    } else {
        FileProvider.getUriForFile(context, FILE_PROVIDER, file)
    }
}

[stale]

This issue has been automatically marked as stale because it has not had activity in the last seven days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

[sjudd]

You can still load the requested image as a byte[] with .as(byte[].class): http://bumptech.github.io/glide/doc/options.html#picking-a-resource-type, http://bumptech.github.io/glide/javadocs/480/com/bumptech/glide/RequestManager.html#as-java.lang.Class-.

For SimpleTarget, see: #3304

[jt-gilkeson]

Can't seem to get that to work in Kotlin any idea on what the syntax would be?

Also in onResourceReady is this the right way to clean things up / necessary:

someView.post {
    Glide.with(this@MyActivity).clear(this)
}

I want to basically do what @TWiStErRob is doing here using Glide v4 and Kotlin : #1424 (comment)

but can't for the life of me figure out if it's still possible and what the syntax would be.

[sjudd]

Not tested, but I think the v4 version of that issue comment is:

Glide.with(context)
  .as(byte[].class)
  .load(url)
  .apply(new RequestOptions()
    .override(MAX_IMAGE_SIZE, MAX_IMAGE_SIZE)
    .diskCacheStrategy(DiskCacheStrategy.DATA)
    .skipMemoryCache(true)
    .downsample(DownsampleStrategy.AT_MOST))
  .into(new SimpleTarget<byte[]>() {
        @Override public void onResourceReady(byte[] resource, GlideAnimation<? super byte[]> ignore 
 {
            new SaveAsFileTask().execute(resource);
        }
        @Override public void onLoadFailed(Exception ex, Drawable ignore) {
            toastUser("Whops, can't load " + link);
        }
        @Override public void onLoadCleared(Drawable ignored) {
          // Assert that SaveAsFileTask is cancelled and won't run, or already finished...
        }
    })

[stale]

This issue has been automatically marked as stale because it has not had activity in the last seven days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.