-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleTarget deprecated #3304
Comments
I have same issue, too |
This issue has been automatically marked as stale because it has not had activity in the last seven days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions. |
I am also having this issue. |
Extending Target directly requires implementing some not totally trivial boilerplate logic in set/getRequest and getSize. This class does not implement onLoadCleared, and should provide an implementation safer than BaseTarget and SimpleTarget, but more convenient than just the Target interface. See bumptech#3304 for an example request for this class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212743879
This issue has been automatically marked as stale because it has not had activity in the last seven days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions. |
Same issue :( |
A simpler alternative will be available in 4.9.0 from: sjudd@b3b2d7a |
Try changing Target to CustomViewTarget. |
@sjudd When do you think |
What is supposed to be the replacement of SimpleTarget ? If there isn't, why deprecate it? |
So what should we do until then? Just keep using SimpleTarget? |
@jackz314 Probably. |
there is a viewTarget in glide 4.8 but it is complex |
Please update the getting started docs: https://bumptech.github.io/glide/doc/getting-started.html Here, SimpleTarget is still used. |
@sjudd, please respond properly to above questions. What is to be used instead of SimpleTarget? 4.9.0 is here, but the tutorial uses simpletarget. Please update the tutorial. Thanks! |
I am having the same issue, can't find a replacement anywhere, no mention in the docs. Official docs still use the 3.9.0, someone f'd up real bad here by not releasing their work. |
@chjan - see the earlier comments, you want CustomTarget, or just don't use SimpleTarget and extend Target, that's also fine. There's some detail in the deprecation message about which other targets to use - http://bumptech.github.io/glide/javadocs/490/com/bumptech/glide/request/target/SimpleTarget.html. I will update the getting started docs, thanks @cristan for the link |
Same issue. I've used Glide (4.9.0), but onResourceReady has not been called. |
Here is the solution Glide
|
@vijayamurugan Should we worry about onLoadCleared ?
I don't understand its usage. Do we need to put there something ? If so, what, and in which cases? |
Since latest update of Glide (4.8.0)
SimpleTarget
has been deprecated so instead of it i useTarget
as mention in this issue #3294 , but doesn't work at all theonResourceReady
method is not called .The text was updated successfully, but these errors were encountered: