Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect theme when loading Drawables while AppCompat is present #2999

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Respect theme when loading Drawables while AppCompat is present #2999

merged 1 commit into from
Mar 30, 2018

Conversation

jlnstrk
Copy link
Contributor

@jlnstrk jlnstrk commented Mar 30, 2018

Description

Makes DrawableDecoderCompat#loadDrawableV7 wrap a now passed Resources.Theme with the present Context, in order for the former to be respected as AppCompat tries to load the Drawable resource

Motivation and Context

Resolves #2783

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jlnstrk
Copy link
Contributor Author

jlnstrk commented Mar 30, 2018

Signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@sjudd
Copy link
Collaborator

sjudd commented Mar 30, 2018

Thanks!

@sjudd sjudd merged commit 5212e95 into bumptech:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants