Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update overrides.json #32

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

t-huyeng
Copy link
Member

  • added pegel-online documentationURL so that we can merge [bot] Update API list #30 after next refresh.

  • formatting of overrides.json

added pegel-online documentationURL, formatting
@t-huyeng t-huyeng requested a review from wirthual October 17, 2022 17:04
@wirthual
Copy link
Member

I think you should also add pypi url to the pegel API.

@t-huyeng
Copy link
Member Author

t-huyeng commented Oct 18, 2022

I think you should also add pypi url to the pegel API.

This is probably a design decision:

It works like this see: Test Workflow (See Show git diff of index.json to Bot-create-pull-request).

diff --git a/index.json b/index.json
index 33c0c13..a10b78d 100644
--- a/index.json
+++ b/index.json
@@ -2[6](https://github.com/t-huyeng/bunddev-apis/actions/runs/3272268689/jobs/5383069788#step:7:7)4,[7](https://github.com/t-huyeng/bunddev-apis/actions/runs/3272268689/jobs/5383069788#step:7:8) +264,7 @@
     "name": "Pegel-Online API",
     "office": "Wasserstraßen- und Schifffahrtsverwaltung",
     "description": "Pegelstände der Messstellen des bundesweiten Messstellennetzes der Wasserstraßen- und Schifffahrtsverwaltung des Bundes.",
-    "documentationURL": "",
+    "documentationURL": "https://pegel-online.api.bund.dev/",
     "githubURL": "https://github.com/bundesAPI/pegel-online-api",
     "rawOpenAPI": "https://raw.githubusercontent.com/bundesAPI/pegel-online-api/main/openapi.yaml",
     "pypiURL": "https://pypi.org/project/de-pegel-online"

So at the moment the pypiURL gets added by the "normal" refresh.

But of course it is different from the current overrides.json inputs.

I think it would be better to have a slim overrides.json file which only contains the actually values which need to be overridden.

@t-huyeng t-huyeng merged commit a156387 into bundesAPI:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants