Handle errors of file IO #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
added a commit
that referenced
this pull request
Feb 20, 2020
### Added - Support for `template.new()` and `template.new(options)` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.root` and `template.location` properties ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 20, 2020
### Added - Support for `template.new()` and `template.new(options)` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.root` and `template.location` properties ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
Merged
bungle
added a commit
that referenced
this pull request
Feb 20, 2020
### Added - Support for `template.new()` and `template.new(options)` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.root` and `template.location` properties ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()` and `template.new(options)` - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()` and `template.new(options)` - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()` and `template.new(options)` - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function` (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function` (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function` (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function` (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function` (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 21, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 24, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 24, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
bungle
added a commit
that referenced
this pull request
Feb 24, 2020
### Added - Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (#36) ### Changed - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (#32) ### Fixed - Wrong template returned when using multiple server blocks (#25) - Add a pure lua configure method (#23, #7)
|
With That will not |
olegrok
pushed a commit
to tarantool/template
that referenced
this pull request
May 9, 2020
- Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (bungle#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (bungle#36) - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (bungle#32) - Wrong template returned when using multiple server blocks (bungle#25) - Add a pure lua configure method (bungle#23, #7)
olegrok
pushed a commit
to tarantool/template
that referenced
this pull request
May 9, 2020
- Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (bungle#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (bungle#36) - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (bungle#32) - Wrong template returned when using multiple server blocks (bungle#25) - Add a pure lua configure method (bungle#23, #7)
olegrok
pushed a commit
to tarantool/template
that referenced
this pull request
May 9, 2020
- Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (bungle#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (bungle#36) - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (bungle#32) - Wrong template returned when using multiple server blocks (bungle#25) - Add a pure lua configure method (bungle#23, #7)
olegrok
pushed a commit
to tarantool/template
that referenced
this pull request
Oct 1, 2020
- Support for `template.new()`, `template.new(options)` and `template.new(safe)` (a `boolean`) - Added `safe` implementation `require "resty.template.safe"` - Added `echo` helper function to template (bungle#28) - Added `template.load_file` and `template.load_string` functions - Added `template.compile_file` and `template.compile_string` functions - Added `template.parse_file` and `template.parse_string` functions - Added `template.render_file` and `template.render_string` functions - Added `template.precompile_file` and `template.precompile_string` functions - Added `template.process`, `template.process_file` and `template.process_string` functions - Added `template.root` and `template.location` properties - Added `template.visit` function (bungle#36) - When `plain` equals to `false` the file io issues are considered fatal, and assertions are thrown (bungle#32) - Wrong template returned when using multiple server blocks (bungle#25) - Add a pure lua configure method (bungle#23, #7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that
template.render("template.html")can print thetemplate.htmlstring as the rendering result when an error happened on file load.Unfortunately, this PR is not a perfect solution because it can still render a file name when the file doesn't exist. This module should support a method for treating only file paths something like
template.renderfileIMHO. Additionally, I hope the methods to return an error as a result likeok, err = template.render().I know that you can define your own
template.loadbut it's troublesome since theloadngxmodule is not that simple. Hope having a nicer default.