feat: Temporarily use DEFAULT if SHIZUKU permissions are not granted #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ushie
force-pushed
the
feat/temporary-install-method
branch
from
fa015d5
to
5fcfb5c
Compare
Ushie
changed the title
pylixonly
reviewed
Jul 29, 2024
| @@ -129,7 +130,14 @@ class HomeViewModel( | |||
| downloadManager.downloadUpdate(update) | |||
| isUpdating = false | |||
|
|
|||
| val installer: Installer = when (prefs.installMethod) { | |||
| val installMethod = if (prefs.installMethod == InstallMethod.SHIZUKU && !ShizukuPermissions.waitShizukuPermissions()) { | |||
| // Temporarily use DEFAULT if SHIZUKU permissions are not granted | |||
There was a problem hiding this comment.
Could there be some kind of toast saying the permissions weren't granted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13