Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return base class from createFromJsonString #73

Closed
OGKevin opened this issue Nov 17, 2017 · 0 comments
Closed

Return base class from createFromJsonString #73

OGKevin opened this issue Nov 17, 2017 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Milestone
0.12.4

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Nov 17, 2017

Steps to reproduce:

  1. Create a class from JSON string by using the method createFromJsonString

What should happen:

  1. The return value is casted to the subclass.

What happens:

  1. The return value is casted to BunqModel.

Logs

  • Logs No logs

Extra info:
@OGKevin OGKevin added this to the 0.12.4 milestone Nov 17, 2017
@OGKevin OGKevin self-assigned this Nov 17, 2017
@OGKevin OGKevin changed the title Return static from createFromJsonString Return base class from createFromJsonString Nov 17, 2017
This was referenced Nov 17, 2017
Closed
Closed
Closed
OGKevin added a commit that referenced this issue Nov 17, 2017
@OGKevin
Return static. (#73)
ef623c5 
This ensure that the base class is returned instead of BunqModel.
@OGKevin OGKevin mentioned this issue Nov 17, 2017
Merged
OGKevin added a commit that referenced this issue Nov 21, 2017
@OGKevin
Re-added strict return type. (#73)
c1be5b1
dnl-blkv added a commit that referenced this issue Nov 21, 2017
@dnl-blkv
Merge pull request #74 from bunq/feature/return-base-class-bunq/sdk_p…
d303c7a 
…hp#73

Return static. (#73)
OGKevin added a commit to bunq/sdk_python that referenced this issue Apr 8, 2018
@OGKevin
Increased min python version to 3.6. (bunq/sdk_php#73)
5938de8
OGKevin added a commit to bunq/sdk_python that referenced this issue Apr 8, 2018
@OGKevin
Increased min python version to py36. (bunq/sdk_php#73)
a78cc79
OGKevin added a commit to bunq/sdk_python that referenced this issue Apr 12, 2018
@OGKevin
Fixed commet in setup script. (bunq/sdk_php#73)
eb0c9e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
0.12.4
Development

No branches or pull requests
1 participant
@OGKevin