Request money on Sandbox if balance zero. (bunq/tinker_php#14) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
suggested changes
Apr 5, 2018
src/BunqLib.php
Outdated
| @@ -19,6 +19,7 @@ | |||
| use bunq\Model\Generated\Object\Pointer; | |||
| use bunq\Util\BunqEnumApiEnvironmentType; | |||
| use bunq\Util\InstallationUtil; | |||
| use Habitat\Environment\Environment; | |||
There was a problem hiding this comment.
This can be removed right ? :P
| @@ -85,6 +97,7 @@ public function __construct(BunqEnumApiEnvironmentType $bunqEnumApiEnvironmentTy | |||
| $this->environment = $bunqEnumApiEnvironmentType; | |||
| $this->setupContext(); | |||
| $this->setupCurrentUser(); | |||
| $this->requestSpendingMoneyIfNeeded(); | |||
There was a problem hiding this comment.
TODO: bunq/sdk_php#122
After sdk update.
src/BunqLib.php
Outdated
| */ | ||
| private function requestSpendingMoneyIfNeeded() | ||
| { | ||
| if (BunqEnumApiEnvironmentType::SANDBOX()->equals($this->environment) |
There was a problem hiding this comment.
This logic can be extracted in its own separate method.
|
@OGKevin moving UserContext refresh to new issue. Implemented comments. |
OGKevin
approved these changes
Apr 12, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14