Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated setup.sh to require bunq/sdk_php so that it works out of the box #4

Closed
wants to merge 1 commit into from

Conversation

evharten
Copy link

Add the require, so that it works out of the box without vendor include issues.

@OGKevin
Copy link
Contributor

OGKevin commented Mar 22, 2018

@evharten this should not be needed. sdk_php is defined as dependency in

"bunq/sdk_php": "^0.13.1"
and therefore the command composer install should install it. 🤔

@OGKevin
Copy link
Contributor

OGKevin commented Mar 22, 2018

@evharten could you please create an issue so that we can discuss why you want/need to add this.

Im closing this PR for now.

@OGKevin OGKevin closed this Mar 22, 2018
@evharten
Copy link
Author

It appears to be working now. guess i had an older version of setup.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants