Skip to content

Commit

Permalink
Merge pull request COVESA#482 from bunty95/master
Browse files Browse the repository at this point in the history
@rpath/libqdlt.dylib fix for MacOS
  • Loading branch information
hannesa2 authored Jun 10, 2024
2 parents afb9316 + 1a1c2ee commit 4d02b7e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/Release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,4 @@ jobs:
files: |
DLT-*
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3 changes: 2 additions & 1 deletion scripts/darwin/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ echo Build with CMake
cmake -G Ninja \
-DCMAKE_INSTALL_PREFIX=${INSTALL_DIR} \
-DCMAKE_PREFIX_PATH=/opt/qt512/lib/cmake \
-DCMAKE_OSX_DEPLOYMENT_TARGET=12.7 \
-DCMAKE_BUILD_TYPE=Release \
-DDLT_USE_QT_RPATH=ON \
-DDLT_PARSER=OFF \
-DDLT_PARSER=ON \
-DDLT_APP_DIR_NAME=${APP_DIR_NAME} \
-DDLT_LIBRARY_INSTALLATION_PATH="${APP_DIR_NAME}/Contents/Frameworks" \
-DDLT_EXECUTABLE_INSTALLATION_PATH="${APP_DIR_NAME}/Contents/MacOS" \
Expand Down
3 changes: 2 additions & 1 deletion scripts/darwin/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ id
env
pwd

brew install --ignore-dependencies qt@5
brew update
brew install qt@5
brew link qt@5 --force --overwrite
# https://github.com/Homebrew/homebrew-core/issues/8392
# https://github.com/Homebrew/legacy-homebrew/issues/29938
Expand Down
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ endif()

set_target_properties(dlt-viewer PROPERTIES
RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin
INSTALL_RPATH "$ORIGIN/../lib;$<$<BOOL:${DLT_USE_QT_RPATH}>:${DLT_QT_LIB_DIR}>")
INSTALL_RPATH "$<$<BOOL:${LINUX}>:$ORIGIN/../lib;>$<$<BOOL:${APPLE}>:@loader_path/../Frameworks;>$<$<BOOL:${DLT_USE_QT_RPATH}>:${DLT_QT_LIB_DIR}>")

install(TARGETS dlt-viewer
DESTINATION "${DLT_EXECUTABLE_INSTALLATION_PATH}"
Expand Down

0 comments on commit 4d02b7e

Please sign in to comment.