Skip to content

Commit

Permalink
fix MCA variable scope in coll ucc
Browse files Browse the repository at this point in the history
Changes several variables scope from READONLY to ALL so that they can be set
via MPI_T interface

Signed-off-by: Burlen Loring <bloring@nvidia.com>
  • Loading branch information
Burlen Loring committed Nov 7, 2024
1 parent 25feb3b commit 617e89d
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions ompi/mca/coll/ucc/coll_ucc_component.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/*
* Copyright (c) 2021 Mellanox Technologies. All rights reserved.
* Copyright (c) 2022 NVIDIA Corporation. All rights reserved.
* Copyright (c) 2024 NVIDIA CORPORATION. All rights reserved.
* $COPYRIGHT$
*
* Additional copyrights may follow
Expand Down Expand Up @@ -60,24 +61,24 @@ static int mca_coll_ucc_register(void)
mca_coll_ucc_component_t *cm = &mca_coll_ucc_component;
mca_base_component_t *c = &cm->super.collm_version;
mca_base_component_var_register(c, "priority", "Priority of the UCC coll component",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_priority);
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_priority);

mca_base_component_var_register(c, "verbose", "Verbose level of the UCC coll component",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_verbose);
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_verbose);

mca_base_component_var_register(c, "enable", "[0|1] Enable/Disable the UCC coll component",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_enable);
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_enable);

mca_base_component_var_register(c, "np", "Minimal communicator size for the UCC coll component",
MCA_BASE_VAR_TYPE_INT, NULL, 0, 0,
MCA_BASE_VAR_TYPE_INT, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
OPAL_INFO_LVL_9,
MCA_BASE_VAR_SCOPE_READONLY, &cm->ucc_np);
MCA_BASE_VAR_SCOPE_ALL, &cm->ucc_np);

mca_base_component_var_register(c, MCA_COMPILETIME_VER,
"Version of the libucc library with which Open MPI was compiled",
Expand All @@ -94,14 +95,14 @@ static int mca_coll_ucc_register(void)
cm->cls = "";
mca_base_component_var_register(c, "cls",
"Comma separated list of UCC CLS to be used for team creation",
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0,
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_READONLY, &cm->cls);
MCA_BASE_VAR_TYPE_STRING, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_ALL, &cm->cls);

cm->cts = COLL_UCC_CTS_STR;
mca_base_component_var_register(c, "cts",
"Comma separated list of UCC coll types to be enabled",
MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0,
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_READONLY, &cm->cts);
MCA_BASE_VAR_TYPE_STRING, NULL, 0, MCA_BASE_VAR_FLAG_SETTABLE,
OPAL_INFO_LVL_6, MCA_BASE_VAR_SCOPE_ALL, &cm->cts);
return OMPI_SUCCESS;
}

Expand Down

0 comments on commit 617e89d

Please sign in to comment.