Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

row_values() takes long time in worksheets with lots of data #113

Closed
acilander opened this issue Mar 20, 2014 · 1 comment
Closed

row_values() takes long time in worksheets with lots of data #113

acilander opened this issue Mar 20, 2014 · 1 comment

Comments

@acilander
Copy link

Hello,

I use row_values(1) to get the headings of a table. Now it happens that my script becomes very slow in this line. My worksheet dimension is 23 cols and 2500 rows.

In models.py there is
cells_list = self._fetch_cells() in _list_values(). This looks to me that the complete data in the worksheet is queried before getting just one row. Is there a way around that?
@Tafkas Tafkas mentioned this issue Aug 18, 2014
Closed
@Tafkas
Copy link
Contributor

Tafkas commented Aug 18, 2014

I submitted a PR for this issue: #155

msuozzo added a commit to msuozzo/gspread that referenced this issue Aug 17, 2015
@msuozzo
Optimized row_values and col_values
db2934e 
Removed the _fetch_cells call for each method. This eliminates the
adverse effect on runtime for large worksheets.

Fixes burnash#285, burnash#190, burnash#179, and burnash#113
msuozzo added a commit to msuozzo/gspread that referenced this issue Aug 17, 2015
@msuozzo
Optimized row_values and col_values
b3f082c 
Removed the _fetch_cells call for each method. This eliminates the
adverse effect on runtime for large worksheets.

Fixes burnash#285, burnash#190, burnash#179, and burnash#113
@msuozzo msuozzo mentioned this issue Aug 17, 2015
Merged
@msuozzo msuozzo closed this as completed Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tafkas @msuozzo @acilander