Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup get empty cell value is None #1404

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

lavigne958
Copy link
Collaborator

Fixup regression where getting a cell
on an empty cell should return a valid Cell
object with a value None.

closes #1403

Signed-off-by: Alexandre Lavigne lavigne958@gmail.com

Fixup regression where getting a cell
on an empty cell should return a valid `Cell`
object with a value `None`.

closes #1403

Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
@lavigne958 lavigne958 self-assigned this Feb 1, 2024
Copy link
Collaborator

@alifeee alifeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat. we are back to using first() which I removed the use of, causing this problem. However, I did not see a good reason for me to remove it, so it coming back seems fine.

merge time :)

gspread/worksheet.py Show resolved Hide resolved
gspread/worksheet.py Show resolved Hide resolved
tests/worksheet_test.py Show resolved Hide resolved
@lavigne958 lavigne958 merged commit 0c52198 into master Feb 4, 2024
20 checks passed
@lavigne958 lavigne958 deleted the bugfix/values_range_first_none branch February 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return empty cell to old default (None not "None")
2 participants