Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new auth method API key #1428

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add new auth method API key #1428

merged 1 commit into from
Mar 1, 2024

Conversation

lavigne958
Copy link
Collaborator

Add a new auth method that allows users to open public spreadsheet files with a simple API key.

closes #1096

Add a new auth method that allows users to open public
spreadsheet files with a simple API key.

closes #1096

Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
@lavigne958 lavigne958 self-assigned this Feb 28, 2024
Copy link
Collaborator

@alifeee alifeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! A nice feature :)

Where is the test?

@lavigne958
Copy link
Collaborator Author

This looks good! A nice feature :)

Thanks

Where is the test?

We don't have any test on authentication method.
We use the service account method to run the tests, but we don't have any on others as this requires constant internet connection to actually authenticate.

@lavigne958 lavigne958 merged commit b34a22e into master Mar 1, 2024
10 checks passed
@lavigne958 lavigne958 deleted the feature/api_key branch March 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

open a public sheet by using an API key instead of an oauth
2 participants