Allow "warning" type protected ranges #1439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1437
They were not allowed before because:
It seems that when
add_protected_range
was added it was assumed thateditor_users_emails
was always required. However, warning ranges do not require (and in fact, cannot contain) emails.To fix this issue, we:
editor_users_emails
from andargument
to akeyword argument
(if it is not changed in position, it should still be usable as an argument)warning_only
is set