Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about runnings tests to contrib guide #1465

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented May 13, 2024

I run tests without tox. I find this easier.

I think people should have this knowledge. They should also know that the CI runs tests with tox.

Also removed -v (verbose) and -s (silence stderr/stdout) as I do not think these are useful, and having lots of extra CLI arguments is imposing for new CLI users.

@alifeee alifeee requested a review from lavigne958 May 13, 2024 13:12
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! I'll make the v6.1.1 release without this one, it only updates the documentation which is only on github

@alifeee alifeee merged commit 4eb7c6d into master May 16, 2024
10 checks passed
@alifeee alifeee deleted the docs/contrib branch May 16, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants