Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to remove old auth.console_flow references #1493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mafrosis
Copy link

No description provided.

@alifeee
Copy link
Collaborator

alifeee commented Jul 23, 2024

thanks for the suggestion!

What motivates this change? You remove a keyword argument to some functions. Some people could rely on using these, no?

@alifeee alifeee requested a review from lavigne958 July 23, 2024 14:52
@lavigne958
Copy link
Collaborator

thanks for the suggestion!

What motivates this change? You remove a keyword argument to some functions. Some people could rely on using these, no?

no people can't rely on them as the flow is not working anymore with Google Authentication system.

Thank you for this clean, I forgot about it.

so far no one should be able to use this flow for months, though we should probably keep it for a major release just in case ?

@mafrosis
Copy link
Author

Hey, sorry for the lack of description 😄

For future readers:
googleapis/google-auth-library-python-oauthlib@1fb16be

I was working on some cross-library compatibility regarding Google API auth flows and tokens and such (gspread & kuzmoyev/google-calendar-simple-api & jeremyephron/simplegmail), and I noticed all this effectively dead code in the gspread auth library. Just doing the good citizen open source thing and sending out a PR for y'all

Thanks for gspread, it's awesome 🫡

@lavigne958
Copy link
Collaborator

thanks for this clean-up, effectively it's dead code, though I'd rather merge it in the next major release just in case, we've seen many issues like this before where it should be ok to merge this and it was not for a few users.

We'll keep this PR open for now until we make next major release and then merge it.

thank in advance for this contribution 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants