Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in_shape, defualt kwarg at WorkSheet::get method for resolving issue #947, #985

Closed
wants to merge 5 commits into from

Conversation

ccppoo
Copy link
Contributor

@ccppoo ccppoo commented Jan 30, 2022

closes #947

method _inflate is for literally inflating json-body value got from Google spreadsheet API

by using _inflate it's possible to do the same for batch_get method,

but I'm making PR first then some one could do it instead of me ...

@ccppoo
Copy link
Contributor Author

ccppoo commented Jan 30, 2022

I have no idea whats wrong with linting, I'm getting nothing except venv package files and black is telling me All done
Help

Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ccppoo for this contribution this is great work but I don't understand why you added a new method _inflate.
we already have a function that does the same job in gspread/utils.py:fill_gaps.
In that function we don't handle default values, so you simply need to add default values to it and you should be good to go.

remember that we never change what the API returns us, we take the values and create new structures but never change the original structure.

@ccppoo
Copy link
Contributor Author

ccppoo commented Feb 12, 2022

can't help myself with linting anymore, sorry

@ccppoo ccppoo closed this Feb 12, 2022
@lavigne958
Copy link
Collaborator

lavigne958 commented Feb 13, 2022

No worries. Did you think about what I said above ? What's your opinion on updating the function fill_gaps ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal]: get, get_values filling empty values response from Google Sheet (with expected cells dimension)
2 participants