Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Generated By Dashwave AI] Update message type for direct messages to 'direct' #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dashwave-ci-dev[bot]
Copy link

This PR updates the mobile app to use 'direct' as the message type when sending direct/private messages to align with Zulip servers at API feature level 174. This change ensures compatibility with the new preferred message type for direct messages. No changes are required for typing notifications as the default value is already set to 'direct' for direct/private message typing notifications. For more details, refer to the API design conversation linked in the issue.

Copy link
Author

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

@burnerlee
Copy link
Owner

@dashwave-ci-dev /feedback "please add comments to the chagnes you made"

Copy link
Author

Comments have been added to the changes in the sendMessage.js file to explain the logic behind using 'direct' for private messages when the server supports it.

Copy link
Author

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

@burnerlee
Copy link
Owner

@dashwave-ci-dev /feedback "please add comments to the chagnes you made"

Copy link
Author

Comments have been added to the changes in the sendMessage.js file to explain the logic behind using 'direct' for private messages when the server supports it.

Copy link
Author

Build Status ❌ Failed
Build Time -
📱 Emulation Link -
Logs See Logs
Open in Workspace Dashwave Workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant