[Generated By Dashwave AI] Implement accessibility announcement queuing in OfflineNoticeProvider #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dashwave-ci-dev[bot]](https://avatars.githubusercontent.com/in/804241?s=60&v=4){kind=small}
|
@dashwave-ci-dev /feedback please revert the changes in the src/boot/OfflineNoticeProvider.js file |
|
|
@dashwave-ci-dev /feedback please revert the changes in the src/boot/OfflineNoticeProvider.js file |
|
|
@dashwave-ci-dev /feedback please revert the changes in the src/boot/OfflineNoticeProvider.js file |
|
No changes needed |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of accessibility announcements interrupting each other in the OfflineNoticeProvider component. By utilizing the new
announceForAccessibilityWithOptionsfeature introduced in React Native v0.68, we can queue announcements behind any in-progress speech on iOS. This enhancement ensures a smoother and more polished user experience for those relying on accessibility features. The changes involve updating the existingannounceForAccessibilitycalls to include thequeueoption, allowing announcements to be queued rather than interrupting ongoing announcements. This is a follow-up to the previous issue and PR related to upgrading React Native.